CI: updates to fix publishing universal darwin binaries #6141
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel/beta #6141 +/- ##
============================================
- Coverage 56.48% 56.23% -0.26%
============================================
Files 499 494 -5
Lines 70029 69954 -75
============================================
- Hits 39556 39338 -218
- Misses 27808 27937 +129
- Partials 2665 2679 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Sep 24, 2024
gmalouf
approved these changes
Sep 24, 2024
cce
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some parts of the release pipeline do not account for the change in naming for the universal darwin binary. This PR addresses this.
Note that we also copy the universal binary to arch-specific named files. This is for backwards compatibility with the update.sh script.
The signing script in particular should run across all installs, as it handles it from a single platform. This means the host identifier is incorrect in this invocation.
Test Plan
Tested by manually running parts of this; should verify with the next stable release if merged before then.